-
Notifications
You must be signed in to change notification settings - Fork 234
[FEA] Add from_handle() methods for Program, ObjectCode, and Kernel. #1413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rparolin
wants to merge
12
commits into
NVIDIA:main
Choose a base branch
from
rparolin:rparolin/192_issue_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+482
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Collaborator
Author
|
/ok to test 30dfcdc |
Collaborator
Author
|
/ok to test 47ad63e |
|
leofang
requested changes
Dec 20, 2025
|
|
||
| # TODO: implement from_handle() | ||
| @staticmethod | ||
| def from_handle(handle: int, mod: "ObjectCode" = None) -> "Kernel": |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would open a can of worms and we should be careful. Mainly because
- we cover two sets of driver APIs (function/module vs kernel/library)
- function/kernel are mostly interchangeable, but their parents (module/library) are not IIRC
- bidirectional lookup cannot be done between function and module, but can be between kernel and library
We should discuss this in depth after the holidays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192
This PR implements from_handle() static methods for ObjectCode, Kernel, and Program classes enabling interoperability with foreign CUDA handles.
✨ Key Changes
4.1. Added thread-safe lazy initialization using double-checked locking pattern
4.2. Refactored global state access through helper functions that ensure initialization