Skip to content

Revert StridedLayout #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cpcloud merged 3 commits into from
Dec 15, 2025
Merged

Revert StridedLayout #1370

cpcloud merged 3 commits into from
Dec 15, 2025

Conversation

@leofang
Copy link
Member

@leofang leofang commented Dec 15, 2025 •
edited
Loading

Description

As per #674 (comment) this PR reverts #1283, since we'll move StridedLayout to elsewhere.

The commit from #1363 was reverted first so as to make the revert clean, but I added it back so that it's intact. The commit history should be clean enough to see how this is done.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 15, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang leofang changed the title WIP: Revert StridedLayout Revert StridedLayout Dec 15, 2025
@leofang leofang self-assigned this Dec 15, 2025
@leofang leofang added this to the cuda.core beta 10 milestone Dec 15, 2025
@leofang leofang added P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Dec 15, 2025
@leofang leofang mentioned this pull request Dec 15, 2025
Merged
2 tasks
@leofang leofang marked this pull request as ready for review December 15, 2025 17:56
@leofang leofang requested a review from kkraus14 December 15, 2025 17:56
@leofang
Copy link
Member Author

leofang commented Dec 15, 2025

/ok to test 412ba2c

@leofang
Copy link
Member Author

leofang commented Dec 15, 2025

cc @stiepan for vis

@github-actions

This comment has been minimized.

Sign in to view
cpcloud
cpcloud reviewed Dec 15, 2025
View reviewed changes
cpcloud
cpcloud approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I can't say I agree with the motivation to revert this PR, it's fine to merge.

@stiepan
Copy link
Member

stiepan commented Dec 15, 2025 •
edited
Loading

cc @stiepan for vis

It seems clean. Good that we moved dlpack fix out of this PR after all. 🥲

@leofang, as @cpcloud pointed out, please double check the docs page.

stiepan
stiepan reviewed Dec 15, 2025
View reviewed changes
@cpcloud cpcloud enabled auto-merge (squash) December 15, 2025 19:13
@cpcloud cpcloud merged commit d8e9317 into NVIDIA:main Dec 15, 2025
82 checks passed
@github-actions
Copy link

github-actions bot commented Dec 15, 2025

Doc Preview CI
Preview removed because the pull request was closed or merged.

cpcloud added a commit to cpcloud/cuda-python that referenced this pull request Dec 15, 2025
@cpcloud
revert: revert StridedLayout (NVIDIA#1370)
152a064 
This reverts commit d8e9317.
@cpcloud cpcloud mentioned this pull request Dec 15, 2025
Merged
cpcloud added a commit to cpcloud/cuda-python that referenced this pull request Dec 15, 2025
@cpcloud
revert: revert StridedLayout (NVIDIA#1370)
b2f6141 
This reverts commit d8e9317.
leofang pushed a commit that referenced this pull request Dec 16, 2025
@cpcloud
refactor: privatize StridedLayout as _StridedLayout (#1373)
1f1f479 
* revert: revert `StridedLayout` (#1370)

This reverts commit d8e9317.

* chore: remove strided layout from docs

* chore: privatize stridedlayout

* chore: remove unused cimports
@leofang leofang deleted the purge_strided_layout branch December 16, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpcloud cpcloud cpcloud approved these changes

@kkraus14 kkraus14 Awaiting requested review from kkraus14

+1 more reviewer

@stiepan stiepan stiepan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@leofang leofang

Labels

cuda.core Everything related to the cuda.core module P0 High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 10

Development

Successfully merging this pull request may close these issues.

3 participants

@leofang @stiepan @cpcloud