Skip to content

Conversation

@rparolin
Copy link
Collaborator

This PR adds pixi build system support to cuda_pathfinder, enabling it to be built and tested using pixi alongside cuda_bindings and cuda_core. The changes introduce a new pixi.toml configuration file with support for multiple environments and platforms and the pixi.lock file for reproducible builds/tests.

@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 11, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rparolin rparolin force-pushed the rparolin/pathfinder_pixi_support branch from 76e7816 to e2ce294 Compare December 11, 2025 20:23
@rparolin rparolin requested a review from cpcloud December 11, 2025 20:24
@rparolin
Copy link
Collaborator Author

/ok to test e2ce294

Copy link
Contributor

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This just works.

I ran:

gh checkout 1361
pixi run -e cu13 test

@rparolin
Copy link
Collaborator Author

@greptileai please review

@rparolin rparolin enabled auto-merge (squash) December 11, 2025 20:29
@github-actions

This comment has been minimized.

Comment on lines +10 to +11
[workspace.build-variants]
python = ["3.10.*", "3.11.*", "3.12.*", "3.13.*", "3.14.*"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuda pathfinder is pure python where I think there's a way to do a noarch package to avoid unnecessary build variants by python version?


[environments]
default = { features = ["test"], solve-group = "default" }
cu13 = { features = ["cu13", "test"], solve-group = "cu13" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to support cu12 for pathfinder as well

@rparolin rparolin merged commit 8e63850 into NVIDIA:main Dec 11, 2025
60 of 62 checks passed
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

@leofang leofang added this to the cuda.pathfinder 1.4.0 milestone Dec 14, 2025
@leofang leofang added enhancement Any code-related improvements P1 Medium priority - Should do cuda.pathfinder Everything related to the cuda.pathfinder module labels Dec 14, 2025
rwgk added a commit to rwgk/cuda-python that referenced this pull request Dec 15, 2025
Merged latest changes from main including:
- Added size property to StridedMemoryView (NVIDIA#1363)
- NVML bindings updates (NVIDIA#1360)
- cuda_pathfinder pixi configuration (NVIDIA#1365, NVIDIA#1361)

All changes merged cleanly with no conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.pathfinder Everything related to the cuda.pathfinder module enhancement Any code-related improvements P1 Medium priority - Should do

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants