-
Notifications
You must be signed in to change notification settings - Fork 234
[cuda_pathfinder] Adding pixi support #1361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cuda_pathfinder] Adding pixi support #1361
Conversation
76e7816 to
e2ce294
Compare
|
/ok to test e2ce294 |
cpcloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This just works.
I ran:
gh checkout 1361
pixi run -e cu13 test
|
@greptileai please review |
This comment has been minimized.
This comment has been minimized.
| [workspace.build-variants] | ||
| python = ["3.10.*", "3.11.*", "3.12.*", "3.13.*", "3.14.*"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuda pathfinder is pure python where I think there's a way to do a noarch package to avoid unnecessary build variants by python version?
|
|
||
| [environments] | ||
| default = { features = ["test"], solve-group = "default" } | ||
| cu13 = { features = ["cu13", "test"], solve-group = "cu13" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to support cu12 for pathfinder as well
|
Merged latest changes from main including: - Added size property to StridedMemoryView (NVIDIA#1363) - NVML bindings updates (NVIDIA#1360) - cuda_pathfinder pixi configuration (NVIDIA#1365, NVIDIA#1361) All changes merged cleanly with no conflicts.
This PR adds pixi build system support to cuda_pathfinder, enabling it to be built and tested using pixi alongside cuda_bindings and cuda_core. The changes introduce a new pixi.toml configuration file with support for multiple environments and platforms and the pixi.lock file for reproducible builds/tests.