{Core} aaz: Wrap functools.partial in staticmethod() to remove FutureWarning
#31973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenSilvaAU
requested review from
calvinhzy,
jsntcy,
kairu-ms and
necusjz
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @RenSilvaAU, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds staticmethod decorators to functools.partial calls to ensure compatibility with Python 3.13, which introduced breaking changes in how functools.partial handles static method binding. The change prevents runtime errors and maintains functionality across supported Python versions.
Key changes:
- Wraps existing
functools.partialcalls withstaticmethoddecorator for preview, experimental, and deprecation info attributes - Affects both command group and command decorators in the AAZ command framework
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
Please fix the PR title and lint error. Original error message when run Here is the related PR about this change: python/cpython#121092 |
Co-authored-by: Copilot <[email protected]>
RenSilvaAU
changed the title
Closed
bebound
changed the title
aaz: wrap functools.partial in staticmethod() to remove FutureWarning
bebound
changed the title
aaz: wrap functools.partial in staticmethod() to remove FutureWarningaaz: Wrap functools.partial in staticmethod() to remove FutureWarning
bebound
approved these changes
Aug 26, 2025
kairu-ms
approved these changes
Aug 26, 2025
bebound
pushed a commit
to bebound/azure-cli
that referenced
this pull request
Oct 29, 2025
…FutureWarning (Azure#31973) Co-authored-by: Copilot <[email protected]>
bebound
added a commit
that referenced
this pull request
Nov 24, 2025
…o remove FutureWarning (#32348)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az commandDescription
Added
staticmethodtofunctools.partialto ensure compatibility with Python 3.13.This change addresses a breaking behavior introduced in Python 3.13 where
functools.partialno longer supports static method binding without explicit declaration.The update ensures continued functionality across supported Python versions and prevents runtime errors in affected modules.
Testing Guide
Run unit tests for modules using
functools.partialas a static method.class MyClass:
@staticmethod
def my_method(x):
return x * 2
partial_func = staticmethod(functools.partial(MyClass.my_method, 5))
assert partial_func() == 10
Example:
import functools