Skip to content

Commit 5cc5fdb

Browse files
authored
Merge branch 'main' into roblou/rising-flamingo
2 parents 29c3330 + f6686c6 commit 5cc5fdb

File tree

394 files changed

+12994
-6994
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

394 files changed

+12994
-6994
lines changed

.github/copilot-instructions.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,3 +134,5 @@ function f(x: number, y: string): void { }
134134
- If you create any temporary new files, scripts, or helper files for iteration, clean up these files by removing them at the end of the task
135135
- Never duplicate imports. Always reuse existing imports if they are present.
136136
- Do not use `any` or `unknown` as the type for variables, parameters, or return values unless absolutely necessary. If they need type annotations, they should have proper types or interfaces defined.
137+
- When adding file watching, prefer correlated file watchers (via fileService.createWatcher) to shared ones.
138+
- When adding tooltips to UI elements, prefer the use of IHoverService service.
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
---
2+
agent: Engineering
3+
model: Claude Sonnet 4.5 (copilot)
4+
argument-hint: Give an assignee and or a label/labels. Issues with that assignee and label will be fetched and grouped.
5+
description: Group similar issues.
6+
tools:
7+
- github/search_issues
8+
- agent/runSubagent
9+
- edit/createFile
10+
- edit/editFiles
11+
- read/readFile
12+
---
13+
14+
## Your Task
15+
1. Use a subagent to:
16+
a. Using the GitHub MCP server, fetch only one page (50 per page) of the open issues for the given assignee and label in the `vscode` repository.
17+
b. After fetching a single page, look through the issues and see if there are are any good grouping categories.Output the categories as headers to a local file categorized-issues.md. Do NOT fetch more issue pages yet, make sure to write the categories to the file first.
18+
2. Repeat step 1 (sequentially, don't parallelize) until all pages are fetched and categories are written to the file.
19+
3. Use a subagent to Re-fetch only one page of the issues for the given assignee and label in the `vscode` repository. Write each issue into the categorized-issues.md file under the appropriate category header with a link and the number of upvotes. If an issue doesn't fit into any category, put it under an "Other" category.
20+
4. Repeat step 3 (sequentially, don't parallelize) until all pages are fetched and all issues are written to the file.
21+
5. Within each category, sort the issues by number of upvotes in descending order.
22+
6. Show the categorized-issues.md file as the final output.

.github/prompts/migrate.prompt.md

Lines changed: 184 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,184 @@
1+
---
2+
agent: agent
3+
tools:
4+
[
5+
"github/add_issue_comment",
6+
"github/get_label",
7+
"github/get_me",
8+
"github/issue_read",
9+
"github/issue_write",
10+
"github/search_issues",
11+
"github/search_pull_requests",
12+
"github/search_repositories",
13+
"github/sub_issue_write",
14+
]
15+
---
16+
17+
# Issue Migration Prompt
18+
19+
Use this prompt when migrating issues from one GitHub repository to another (e.g., from `microsoft/vscode-copilot` to `microsoft/vscode`).
20+
21+
## Input Methods
22+
23+
You can specify which issues to migrate using **any** of these three methods:
24+
25+
### Option A: GitHub Search Query URL
26+
27+
Provide a full GitHub issues search URL. **All matching issues will be migrated.**
28+
29+
```
30+
https://github.com/microsoft/vscode-copilot/issues?q=is%3Aissue+is%3Aopen+assignee%3Ayoyokrazy
31+
```
32+
33+
### Option B: GitHub Search Query Parameters
34+
35+
Provide search query syntax for a specific repo. **All matching issues will be migrated.**
36+
37+
```
38+
repo:microsoft/vscode-copilot is:issue is:open assignee:yoyokrazy
39+
```
40+
41+
Common query filters:
42+
43+
- `is:issue` / `is:pr` - Filter by type
44+
- `is:open` / `is:closed` - Filter by state
45+
- `assignee:USERNAME` - Filter by assignee
46+
- `author:USERNAME` - Filter by author
47+
- `label:LABEL` - Filter by label
48+
- `milestone:MILESTONE` - Filter by milestone
49+
50+
### Option C: Specific Issue URL
51+
52+
Provide a direct link to a single issue. **Only this issue will be migrated.**
53+
54+
```
55+
https://github.com/microsoft/vscode-copilot/issues/12345
56+
```
57+
58+
## Task
59+
60+
**Target Repository:** `{TARGET_REPO}`
61+
62+
Based on the input provided, migrate the issue(s) to the target repository following all requirements below.
63+
64+
## Requirements
65+
66+
### 1. Issue Body Format
67+
68+
Create the new issue with this header format:
69+
70+
```markdown
71+
_Transferred from {SOURCE_REPO}#{ORIGINAL_ISSUE_NUMBER}_
72+
_Original author: `@{ORIGINAL_AUTHOR}`_
73+
74+
---
75+
76+
{ORIGINAL_ISSUE_BODY}
77+
```
78+
79+
### 2. Comment Migration
80+
81+
For each comment on the original issue, add a comment to the new issue:
82+
83+
```markdown
84+
_`@{COMMENT_AUTHOR}` commented:_
85+
86+
---
87+
88+
{COMMENT_BODY}
89+
```
90+
91+
### 3. CRITICAL: Preventing GitHub Pings
92+
93+
**ALL `@username` mentions MUST be wrapped in backticks to prevent GitHub from sending notifications.**
94+
95+
✅ Correct: `` `@username` ``
96+
❌ Wrong: `@username`
97+
98+
This applies to:
99+
100+
- The "Original author" line in the issue body
101+
- Any `@mentions` within the issue body content
102+
- The comment author attribution line
103+
- Any `@mentions` within comment content
104+
- Any quoted content that contains `@mentions`
105+
106+
### 4. CRITICAL: Issue/PR Link Reformatting
107+
108+
**Issue references like `#12345` are REPO-SPECIFIC.** If you copy `#12345` from the source repo to the target repo, it will incorrectly link to issue 12345 in the _target_ repo instead of the source.
109+
110+
**Convert ALL `#NUMBER` references to full URLs:**
111+
112+
✅ Correct: `https://github.com/microsoft/vscode-copilot/issues/12345`
113+
✅ Also OK: `microsoft/vscode-copilot#12345`
114+
❌ Wrong: `#12345` (will link to wrong repo)
115+
116+
This applies to:
117+
118+
- Issue references in the body (`#12345` → full URL)
119+
- PR references in the body (`#12345` → full URL)
120+
- References in comments
121+
- References in quoted content
122+
- References in image alt text or links
123+
124+
**Exception:** References that are _already_ full URLs should be left unchanged.
125+
126+
### 5. Metadata Preservation
127+
128+
- Copy all applicable labels to the new issue
129+
- Assign the new issue to the same assignees (if they exist in target repo)
130+
- Preserve the issue title exactly
131+
132+
### 5. Post-Migration
133+
134+
After creating the new issue and all comments:
135+
136+
- Add a comment to the **original** issue linking to the new issue:
137+
```markdown
138+
Migrated to {TARGET_REPO}#{NEW_ISSUE_NUMBER}
139+
```
140+
- Close the original issue as not_planned
141+
142+
## Example Transformation
143+
144+
### Original Issue Body (in `microsoft/vscode-copilot`):
145+
146+
```markdown
147+
I noticed @johndoe had a similar issue in #9999. cc @janedoe for visibility.
148+
149+
Related to #8888 and microsoft/vscode#12345.
150+
151+
Steps to reproduce:
152+
153+
1. Open VS Code
154+
2. ...
155+
```
156+
157+
### Migrated Issue Body (in `microsoft/vscode`):
158+
159+
```markdown
160+
_Transferred from microsoft/vscode-copilot#12345_
161+
_Original author: `@originalauthor`_
162+
163+
---
164+
165+
I noticed `@johndoe` had a similar issue in https://github.com/microsoft/vscode-copilot/issues/9999. cc `@janedoe` for visibility.
166+
167+
Related to https://github.com/microsoft/vscode-copilot/issues/8888 and microsoft/vscode#12345.
168+
169+
Steps to reproduce:
170+
171+
1. Open VS Code
172+
2. ...
173+
```
174+
175+
Note: The `microsoft/vscode#12345` reference was already a cross-repo link, so it stays unchanged.
176+
177+
## Checklist Before Migration
178+
179+
- [ ] Confirm input method (query URL, query params, or specific issue URL)
180+
- [ ] Confirm target repository
181+
- [ ] If using query: verify the query returns the expected issues
182+
- [ ] Verify all `@mentions` are wrapped in backticks
183+
- [ ] Verify all `#NUMBER` references are converted to full URLs
184+
- [ ] Decide whether to close original issues after migration

.github/workflows/copilot-setup-steps.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555

5656
- name: Restore node_modules cache
5757
id: cache-node-modules
58-
uses: actions/cache/restore@v4
58+
uses: actions/cache/restore@v5
5959
with:
6060
path: .build/node_modules_cache
6161
key: "node_modules-linux-${{ hashFiles('.build/packagelockhash') }}"
@@ -119,7 +119,7 @@ jobs:
119119

120120
- name: Restore built-in extensions cache
121121
id: cache-builtin-extensions
122-
uses: actions/cache/restore@v4
122+
uses: actions/cache/restore@v5
123123
with:
124124
enableCrossOsArchive: true
125125
path: .build/builtInExtensions

.github/workflows/monaco-editor.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ jobs:
3232
run: echo "value=$(node build/azure-pipelines/common/computeNodeModulesCacheKey.ts)" >> $GITHUB_OUTPUT
3333
- name: Cache node modules
3434
id: cacheNodeModules
35-
uses: actions/cache@v4
35+
uses: actions/cache@v5
3636
with:
3737
path: "**/node_modules"
3838
key: ${{ runner.os }}-cacheNodeModules20-${{ steps.nodeModulesCacheKey.outputs.value }}
@@ -43,7 +43,7 @@ jobs:
4343
run: echo "dir=$(npm config get cache)" >> $GITHUB_OUTPUT
4444
- name: Cache npm directory
4545
if: ${{ steps.cacheNodeModules.outputs.cache-hit != 'true' }}
46-
uses: actions/cache@v4
46+
uses: actions/cache@v5
4747
with:
4848
path: ${{ steps.npmCacheDirPath.outputs.dir }}
4949
key: ${{ runner.os }}-npmCacheDir-${{ steps.nodeModulesCacheKey.outputs.value }}

.github/workflows/pr-darwin-test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636

3737
- name: Restore node_modules cache
3838
id: cache-node-modules
39-
uses: actions/cache/restore@v4
39+
uses: actions/cache/restore@v5
4040
with:
4141
path: .build/node_modules_cache
4242
key: "node_modules-macos-${{ hashFiles('.build/packagelockhash') }}"
@@ -89,7 +89,7 @@ jobs:
8989

9090
- name: Restore built-in extensions cache
9191
id: cache-builtin-extensions
92-
uses: actions/cache/restore@v4
92+
uses: actions/cache/restore@v5
9393
with:
9494
enableCrossOsArchive: true
9595
path: .build/builtInExtensions
@@ -212,7 +212,7 @@ jobs:
212212
if: always()
213213

214214
- name: Publish Crash Reports
215-
uses: actions/upload-artifact@v5
215+
uses: actions/upload-artifact@v6
216216
if: failure()
217217
continue-on-error: true
218218
with:
@@ -223,7 +223,7 @@ jobs:
223223
# In order to properly symbolify above crash reports
224224
# (if any), we need the compiled native modules too
225225
- name: Publish Node Modules
226-
uses: actions/upload-artifact@v5
226+
uses: actions/upload-artifact@v6
227227
if: failure()
228228
continue-on-error: true
229229
with:
@@ -232,7 +232,7 @@ jobs:
232232
if-no-files-found: ignore
233233

234234
- name: Publish Log Files
235-
uses: actions/upload-artifact@v5
235+
uses: actions/upload-artifact@v6
236236
if: always()
237237
continue-on-error: true
238238
with:

.github/workflows/pr-linux-test.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353

5454
- name: Restore node_modules cache
5555
id: cache-node-modules
56-
uses: actions/cache/restore@v4
56+
uses: actions/cache/restore@v5
5757
with:
5858
path: .build/node_modules_cache
5959
key: "node_modules-linux-${{ hashFiles('.build/packagelockhash') }}"
@@ -117,7 +117,7 @@ jobs:
117117

118118
- name: Restore built-in extensions cache
119119
id: cache-builtin-extensions
120-
uses: actions/cache/restore@v4
120+
uses: actions/cache/restore@v5
121121
with:
122122
enableCrossOsArchive: true
123123
path: .build/builtInExtensions
@@ -258,7 +258,7 @@ jobs:
258258
if: always()
259259

260260
- name: Publish Crash Reports
261-
uses: actions/upload-artifact@v5
261+
uses: actions/upload-artifact@v6
262262
if: failure()
263263
continue-on-error: true
264264
with:
@@ -269,7 +269,7 @@ jobs:
269269
# In order to properly symbolify above crash reports
270270
# (if any), we need the compiled native modules too
271271
- name: Publish Node Modules
272-
uses: actions/upload-artifact@v5
272+
uses: actions/upload-artifact@v6
273273
if: failure()
274274
continue-on-error: true
275275
with:
@@ -278,7 +278,7 @@ jobs:
278278
if-no-files-found: ignore
279279

280280
- name: Publish Log Files
281-
uses: actions/upload-artifact@v5
281+
uses: actions/upload-artifact@v6
282282
if: always()
283283
continue-on-error: true
284284
with:

.github/workflows/pr-node-modules.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525

2626
- name: Restore node_modules cache
2727
id: cache-node-modules
28-
uses: actions/cache@v4
28+
uses: actions/cache@v5
2929
with:
3030
path: .build/node_modules_cache
3131
key: "node_modules-compile-${{ hashFiles('.build/packagelockhash') }}"
@@ -72,7 +72,7 @@ jobs:
7272
7373
- name: Restore built-in extensions cache
7474
id: cache-builtin-extensions
75-
uses: actions/cache@v4
75+
uses: actions/cache@v5
7676
with:
7777
enableCrossOsArchive: true
7878
path: .build/builtInExtensions
@@ -104,7 +104,7 @@ jobs:
104104

105105
- name: Restore node_modules cache
106106
id: cache-node-modules
107-
uses: actions/cache@v4
107+
uses: actions/cache@v5
108108
with:
109109
path: .build/node_modules_cache
110110
key: "node_modules-linux-${{ hashFiles('.build/packagelockhash') }}"
@@ -176,7 +176,7 @@ jobs:
176176

177177
- name: Restore node_modules cache
178178
id: cache-node-modules
179-
uses: actions/cache@v4
179+
uses: actions/cache@v5
180180
with:
181181
path: .build/node_modules_cache
182182
key: "node_modules-macos-${{ hashFiles('.build/packagelockhash') }}"
@@ -239,7 +239,7 @@ jobs:
239239
node build/azure-pipelines/common/computeNodeModulesCacheKey.ts win32 ${{ env.VSCODE_ARCH }} $(node -p process.arch) > .build/packagelockhash
240240
241241
- name: Restore node_modules cache
242-
uses: actions/cache@v4
242+
uses: actions/cache@v5
243243
id: node-modules-cache
244244
with:
245245
path: .build/node_modules_cache

0 commit comments

Comments
 (0)