From eeb8692c4c663d69bd3dd1c02da2b296dd1b9d6f Mon Sep 17 00:00:00 2001
From: Matt Todd <chiology@gmail.com>
Date: Wed, 24 Sep 2014 20:34:48 -0700
Subject: [PATCH 1/6] Add failing test for items with links

---
 test/unit/test_updates.coffee | 58 +++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/test/unit/test_updates.coffee b/test/unit/test_updates.coffee
index c5b55e5..2fc417c 100644
--- a/test/unit/test_updates.coffee
+++ b/test/unit/test_updates.coffee
@@ -506,3 +506,61 @@ asyncTest "update ignores items that look like Task List items but are links", -
   , 20
 
   item2Checkbox.click()
+
+asyncTest "updates items followed by links", ->
+  expect 3
+
+  $('#qunit-fixture').empty()
+
+  container = $ '<div>', class: 'js-task-list-container'
+
+  list = $ '<ul>', class: 'task-list'
+
+  item1 = $ '<li>', class: 'task-list-item'
+  item1Checkbox = $ '<input>',
+    type: 'checkbox'
+    class: 'task-list-item-checkbox'
+    disabled: true
+    checked: false
+
+  item2 = $ '<li>', class: 'task-list-item'
+  item2Checkbox = $ '<input>',
+    type: 'checkbox'
+    class: 'task-list-item-checkbox'
+    disabled: true
+    checked: false
+
+  field = $ '<textarea>', class: 'js-task-list-field', text: """
+    - [ ] [link label](link)
+    - [ ] [reference label][reference]
+  """
+
+  changes = """
+    - [ ] [link label](link)
+    - [x] [reference label][reference]
+  """
+
+  item1.append item1Checkbox
+  list.append item1
+  item1.expectedIndex = 1
+
+  item2.append item2Checkbox
+  list.append item2
+  item2.expectedIndex = 2
+
+  container.append list
+  container.append field
+
+  $('#qunit-fixture').append(container)
+  container.taskList()
+
+  field.on 'tasklist:changed', (event, index, checked) =>
+    ok checked
+    equal index, item2.expectedIndex
+    equal field.val(), changes
+
+  setTimeout ->
+    start()
+  , 20
+
+  item2Checkbox.click()

From e10391544eecdd11b5548e159f4ee0573e9f63ed Mon Sep 17 00:00:00 2001
From: Matt Todd <chiology@gmail.com>
Date: Thu, 25 Sep 2014 16:32:37 -0700
Subject: [PATCH 2/6] Split link dest from link reference, more explicit

Still fails, though. cc @aroben
---
 app/assets/javascripts/task_list.coffee | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/app/assets/javascripts/task_list.coffee b/app/assets/javascripts/task_list.coffee
index fbb08d8..2c46b33 100644
--- a/app/assets/javascripts/task_list.coffee
+++ b/app/assets/javascripts/task_list.coffee
@@ -125,10 +125,20 @@ itemPattern = ///
     #{escapePattern(complete)}|
     #{escapePattern(incomplete)}
   )
-  (?!                     # is not a link
-    \s*                   # with optional whitespace
-    (?:\(.*?\)|\[.*?\])   # because of destination or reference
+  (?!                     # but not a link to this destination
+    \s*
+    \(.*?\)
   )
+  (?=                     # and not part of a link reference
+    \s*
+    (?:(?:\[.*?\]\s*){2})*
+    (?:[^\[]|$)
+  )
+  # (?!                     # is not a link
+  #   \s*                   # with optional whitespace
+  #   (?:\(.*?\)|\[.*?\])   # because of destination or reference
+  #   (?:\s*[^\[\(])        # but itself not first part of a link
+  # )
   (?=\s)                  # is followed by whitespace
 ///
 

From fdca517ecb67e574e1df7cde190acc5323703c20 Mon Sep 17 00:00:00 2001
From: Matt Todd <chiology@gmail.com>
Date: Thu, 25 Sep 2014 16:39:48 -0700
Subject: [PATCH 3/6] Move required whitespace earlier

---
 app/assets/javascripts/task_list.coffee | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/assets/javascripts/task_list.coffee b/app/assets/javascripts/task_list.coffee
index 2c46b33..3c0f858 100644
--- a/app/assets/javascripts/task_list.coffee
+++ b/app/assets/javascripts/task_list.coffee
@@ -125,6 +125,7 @@ itemPattern = ///
     #{escapePattern(complete)}|
     #{escapePattern(incomplete)}
   )
+  (?=\s)                  # is followed by whitespace
   (?!                     # but not a link to this destination
     \s*
     \(.*?\)
@@ -139,7 +140,6 @@ itemPattern = ///
   #   (?:\(.*?\)|\[.*?\])   # because of destination or reference
   #   (?:\s*[^\[\(])        # but itself not first part of a link
   # )
-  (?=\s)                  # is followed by whitespace
 ///
 
 # Used to filter out code fences from the source for comparison only.

From b628d7a4ea5af88ee6de12794707dc348d450b7f Mon Sep 17 00:00:00 2001
From: Matt Todd <chiology@gmail.com>
Date: Thu, 25 Sep 2014 16:50:12 -0700
Subject: [PATCH 4/6] Revert ignoring link references

Punting on proper handling for now.
---
 app/assets/javascripts/task_list.coffee | 10 ----------
 test/unit/test_updates.coffee           |  8 ++++----
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/app/assets/javascripts/task_list.coffee b/app/assets/javascripts/task_list.coffee
index 3c0f858..f5cf946 100644
--- a/app/assets/javascripts/task_list.coffee
+++ b/app/assets/javascripts/task_list.coffee
@@ -130,16 +130,6 @@ itemPattern = ///
     \s*
     \(.*?\)
   )
-  (?=                     # and not part of a link reference
-    \s*
-    (?:(?:\[.*?\]\s*){2})*
-    (?:[^\[]|$)
-  )
-  # (?!                     # is not a link
-  #   \s*                   # with optional whitespace
-  #   (?:\(.*?\)|\[.*?\])   # because of destination or reference
-  #   (?:\s*[^\[\(])        # but itself not first part of a link
-  # )
 ///
 
 # Used to filter out code fences from the source for comparison only.
diff --git a/test/unit/test_updates.coffee b/test/unit/test_updates.coffee
index 2fc417c..68d96c9 100644
--- a/test/unit/test_updates.coffee
+++ b/test/unit/test_updates.coffee
@@ -466,18 +466,18 @@ asyncTest "update ignores items that look like Task List items but are links", -
 
   field = $ '<textarea>', class: 'js-task-list-field', text: """
     - [ ] (link)
-    - [ ] [reference]
+    # - [ ] [reference]
     - [ ] () collapsed
-    - [ ] [] collapsed reference
+    # - [ ] [] collapsed reference
     - [ ] \\(escaped item)
     - [ ] item
   """
 
   changes = """
     - [ ] (link)
-    - [ ] [reference]
+    # - [ ] [reference]
     - [ ] () collapsed
-    - [ ] [] collapsed reference
+    # - [ ] [] collapsed reference
     - [ ] \\(escaped item)
     - [x] item
   """

From 765f60f87fb8ba6c56d39508153de20ef6a887e9 Mon Sep 17 00:00:00 2001
From: Matt Todd <chiology@gmail.com>
Date: Thu, 25 Sep 2014 17:18:42 -0700
Subject: [PATCH 5/6] Got it

---
 app/assets/javascripts/task_list.coffee | 15 +++++++++++----
 test/unit/test_updates.coffee           |  8 ++++----
 2 files changed, 15 insertions(+), 8 deletions(-)

diff --git a/app/assets/javascripts/task_list.coffee b/app/assets/javascripts/task_list.coffee
index f5cf946..7af2592 100644
--- a/app/assets/javascripts/task_list.coffee
+++ b/app/assets/javascripts/task_list.coffee
@@ -125,10 +125,17 @@ itemPattern = ///
     #{escapePattern(complete)}|
     #{escapePattern(incomplete)}
   )
-  (?=\s)                  # is followed by whitespace
-  (?!                     # but not a link to this destination
-    \s*
-    \(.*?\)
+  \s+                     # is followed by whitespace
+  (                       # followed by anything unmistakable for a link,
+    ([^\[\(]|$)           # or end of line
+  |
+    (?!
+      \(.*?\)             # or, not immediately followed by a link URL
+    )
+    (                     # and not part of a link reference
+      (\[.*?\]\s*(\[.*?\]|\(.*?\))\s*)+
+      ([^\[]|$)
+    )
   )
 ///
 
diff --git a/test/unit/test_updates.coffee b/test/unit/test_updates.coffee
index 68d96c9..2fc417c 100644
--- a/test/unit/test_updates.coffee
+++ b/test/unit/test_updates.coffee
@@ -466,18 +466,18 @@ asyncTest "update ignores items that look like Task List items but are links", -
 
   field = $ '<textarea>', class: 'js-task-list-field', text: """
     - [ ] (link)
-    # - [ ] [reference]
+    - [ ] [reference]
     - [ ] () collapsed
-    # - [ ] [] collapsed reference
+    - [ ] [] collapsed reference
     - [ ] \\(escaped item)
     - [ ] item
   """
 
   changes = """
     - [ ] (link)
-    # - [ ] [reference]
+    - [ ] [reference]
     - [ ] () collapsed
-    # - [ ] [] collapsed reference
+    - [ ] [] collapsed reference
     - [ ] \\(escaped item)
     - [x] item
   """

From 9bd8e697e6096d2eb2b92a3a737405c3d639d171 Mon Sep 17 00:00:00 2001
From: Adam Roben <adam@roben.org>
Date: Thu, 25 Sep 2014 20:32:52 -0400
Subject: [PATCH 6/6] Simplify the regex a little bit

---
 app/assets/javascripts/task_list.coffee | 16 ++++++----------
 1 file changed, 6 insertions(+), 10 deletions(-)

diff --git a/app/assets/javascripts/task_list.coffee b/app/assets/javascripts/task_list.coffee
index 7af2592..5f115f5 100644
--- a/app/assets/javascripts/task_list.coffee
+++ b/app/assets/javascripts/task_list.coffee
@@ -126,16 +126,12 @@ itemPattern = ///
     #{escapePattern(incomplete)}
   )
   \s+                     # is followed by whitespace
-  (                       # followed by anything unmistakable for a link,
-    ([^\[\(]|$)           # or end of line
-  |
-    (?!
-      \(.*?\)             # or, not immediately followed by a link URL
-    )
-    (                     # and not part of a link reference
-      (\[.*?\]\s*(\[.*?\]|\(.*?\))\s*)+
-      ([^\[]|$)
-    )
+  (?!
+    \(.*?\)               # is not part of a [foo](url) link
+  )
+  (?=                     # and is followed by zero or more links
+    (?:\[.*?\]\s*(?:\[.*?\]|\(.*?\))\s*)*
+    (?:[^\[]|$)           # and either a non-link or the end of the string
   )
 ///